fix: Project type appears twice under system and password prompts when cloud system is selected. #3706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dditionalMessage to be consistent with the password prompt mutation.
🦋 Changeset detectedLatest commit: acf883b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
avasilev-sap
changed the title
avasilev-sap
changed the title
mmilko01
approved these changes
Oct 8, 2025
nikmace
approved these changes
Oct 8, 2025
|
devinea
added a commit
that referenced
this pull request
Oct 15, 2025
…chart_on_list_v4 * origin/main: chore: apply latest changesets feat(fpm-writer): table building block custom columns (#3665) chore: apply latest changesets fix: Project type appears twice under system and password prompts when cloud system is selected. (#3706) chore: apply latest changesets fix(adp)(vscode): SAP Fiori Launchpad Configuration step appears multiple times. (#3683) chore: apply latest changesets update axios version (#3732) chore: apply latest changesets fix(fiori-annotation-api): wrong origin range (#3729) chore: apply latest changesets TBI - Replace service key (UAA/OAuth2) based connections with re-entrance tickets (#3693) chore: apply latest changesets fix: smartlinks target prompt (#3643) chore: apply latest changesets feat: Add ADP Generator Cloud Foundry prompting code (#3518)
devinea
added a commit
that referenced
this pull request
Oct 16, 2025
…r_RAG_code_gen * origin/main: (26 commits) chore: apply latest changesets feat(odata-service-inquirer): 35947 default table type (#3725) chore: apply latest changesets Fix/35934/incorrect entity list rich text editor (#3724) fix: Remove CF flow from the ADP Generator and fix template resolution problem (#3735) chore: apply latest changesets fix: vocabulary update (#3733) chore: apply latest changesets feat(fiori-mcp-server): add fiori_development_portal_extension.md, etc... (#3717) fix: schedule ui integration tests on every workday (#3620) chore: apply latest changesets feat(fpm-writer): table building block custom columns (#3665) chore: apply latest changesets fix: Project type appears twice under system and password prompts when cloud system is selected. (#3706) chore: apply latest changesets fix(adp)(vscode): SAP Fiori Launchpad Configuration step appears multiple times. (#3683) chore: apply latest changesets update axios version (#3732) chore: apply latest changesets fix(fiori-annotation-api): wrong origin range (#3729) ...
devinea
added a commit
that referenced
this pull request
Oct 16, 2025
* origin/main: (286 commits) chore: apply latest changesets feat(odata-service-inquirer): 35947 default table type (#3725) chore: apply latest changesets Fix/35934/incorrect entity list rich text editor (#3724) fix: Remove CF flow from the ADP Generator and fix template resolution problem (#3735) chore: apply latest changesets fix: vocabulary update (#3733) chore: apply latest changesets feat(fiori-mcp-server): add fiori_development_portal_extension.md, etc... (#3717) fix: schedule ui integration tests on every workday (#3620) chore: apply latest changesets feat(fpm-writer): table building block custom columns (#3665) chore: apply latest changesets fix: Project type appears twice under system and password prompts when cloud system is selected. (#3706) chore: apply latest changesets fix(adp)(vscode): SAP Fiori Launchpad Configuration step appears multiple times. (#3683) chore: apply latest changesets update axios version (#3732) chore: apply latest changesets fix(fiori-annotation-api): wrong origin range (#3729) ...
tom-sap
added a commit
that referenced
this pull request
Oct 16, 2025
* main: (61 commits) chore: apply latest changesets feat(odata-service-inquirer): 35947 default table type (#3725) chore: apply latest changesets Fix/35934/incorrect entity list rich text editor (#3724) fix: Remove CF flow from the ADP Generator and fix template resolution problem (#3735) chore: apply latest changesets fix: vocabulary update (#3733) chore: apply latest changesets feat(fiori-mcp-server): add fiori_development_portal_extension.md, etc... (#3717) fix: schedule ui integration tests on every workday (#3620) chore: apply latest changesets feat(fpm-writer): table building block custom columns (#3665) chore: apply latest changesets fix: Project type appears twice under system and password prompts when cloud system is selected. (#3706) chore: apply latest changesets fix(adp)(vscode): SAP Fiori Launchpad Configuration step appears multiple times. (#3683) chore: apply latest changesets update axios version (#3732) chore: apply latest changesets fix(fiori-annotation-api): wrong origin range (#3729) ...
eouin
added a commit
that referenced
this pull request
Oct 22, 2025
…ter/building-block-custom-filter * 'main' of github.com:SAP/open-ux-tools: chore: apply latest changesets feat(fiori-mcp-server): add fiori_development_portal_extension.md, etc... (#3717) fix: schedule ui integration tests on every workday (#3620) chore: apply latest changesets feat(fpm-writer): table building block custom columns (#3665) chore: apply latest changesets fix: Project type appears twice under system and password prompts when cloud system is selected. (#3706) chore: apply latest changesets fix(adp)(vscode): SAP Fiori Launchpad Configuration step appears multiple times. (#3683) chore: apply latest changesets update axios version (#3732) chore: apply latest changesets fix(fiori-annotation-api): wrong origin range (#3729) chore: apply latest changesets TBI - Replace service key (UAA/OAuth2) based connections with re-entrance tickets (#3693) chore: apply latest changesets fix: smartlinks target prompt (#3643)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3698
Add system additional message as a state property of the config prompter in the ADP generator. For a system which requires authentication in order to determine the project type we need to first authenticate to the system. The system additional message contains the project type needed. The message can be set from the system prompt when the system does not require authentication or later in the password prompt when the login completes. In order to prevent from displaying the message twice we maintain a state pointing to the message in the prompter. Only one prompt - system or password could display that message.
Testing done:
Test scenario:
=> When the login completes the project type appears beneath the system prompt.
Test scenario:
=> The project type appears beneath the password prompt.